[ 
https://issues.apache.org/jira/browse/HDFS-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599556#comment-13599556
 ] 

Ivan Mitic commented on HDFS-4287:
----------------------------------

Thanks Chris for addressing the comments! One minor comment, otherwise +1 from 
me

 - TestServer#contructorsGetters(): I think we can avoid the {{if WINDOWS 
check) and the hardcoded "C:/" if we have a File object for a {{drive}} and 
then pass {{new File(drive, child).getAbsolutePath()}} to the Server 
constructor and asserts. You can use {{test.build.data}} for a test base dir. 
Make sense?

I verified that the now tests pass on my box.
                
> HTTPFS tests fail on Windows
> ----------------------------
>
>                 Key: HDFS-4287
>                 URL: https://issues.apache.org/jira/browse/HDFS-4287
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: webhdfs
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-4287.1.patch, HDFS-4287.2.patch, HDFS-4287.3.patch
>
>
> The HTTPFS tests have some platform-specific assumptions that cause the tests 
> to fail when run on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to