[ 
https://issues.apache.org/jira/browse/HDFS-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599562#comment-13599562
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4563:
----------------------------------------------

Thanks Jing.  It is great that you figure out getting around the javac bug.

- INodeContent could easily be confused with other INodeXxx classes.  How about 
renaming it to Content?

- In INodeDirectoryWithQuota, we have addConsumed and addSpaceConsumed.  How 
about calling them addSpaceConsumed and addSpaceConsumed2Cache?  Also the 
addConsumed method should call the other method for updating cache.

- We only have to add a new generic type to processor but don't need to change 
the generic types of Diff.  i.e.
{code}
-  public static interface Processor<E> {
+  public static interface Processor<E, C> {
{code}
and 
{code}
-  public int combinePosterior(final Diff<K, E> posterior,
-      final Processor<E> deletedProcesser) {
+  public <C> void combinePosterior(final Diff<K, E> posterior,
+      final C counts, final Processor<E, C> deletedProcesser) {
{code}
                
> Update namespace/diskspace after deleting snapshots
> ---------------------------------------------------
>
>                 Key: HDFS-4563
>                 URL: https://issues.apache.org/jira/browse/HDFS-4563
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4563.001.patch, HDFS-4563.002.patch
>
>
> 1. Update namespace/diskspace after deleting snapshots
> 2. Compute quota usage when an INodeDirectoryWithSnapshot is first assigned 
> with quota
> 3. Add more unit tests covering quota usage computation

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to