[ 
https://issues.apache.org/jira/browse/HDFS-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599834#comment-13599834
 ] 

Hadoop QA commented on HDFS-4592:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12573271/HDFS-4592.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.datanode.TestDataDirs

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/4087//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4087//console

This message is automatically generated.
                
> Default values for access time precision are out of sync between 
> hdfs-default.xml and the code
> ----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4592
>                 URL: https://issues.apache.org/jira/browse/HDFS-4592
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.0.4-alpha
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Minor
>         Attachments: HDFS-4592.patch
>
>
> In {{hdfs-default.xml}} we have:
> {code}
> <property>
>   <name>dfs.namenode.accesstime.precision</name>
>   <value>3600000</value>
>   <description>The access time for HDFS file is precise upto this value.
>                The default value is 1 hour. Setting a value of 0 disables
>                access times for HDFS.
>   </description>
> </property>
> {code}
> But in {{FSNamesystem}} we have:
> {code}
> this.accessTimePrecision = 
> conf.getLong(DFS_NAMENODE_ACCESSTIME_PRECISION_KEY, 0);
> {code}
> We properly define {{DFS_NAMENODE_ACCESSTIME_PRECISION_DEFAULT}} in 
> DFSConfigKeys.java, but it's not actually referenced anywhere in the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to