[ 
https://issues.apache.org/jira/browse/HDFS-4595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600598#comment-13600598
 ] 

Colin Patrick McCabe commented on HDFS-4595:
--------------------------------------------

This bug was fixed in HDFS-347.  However, since we have decided to keep the 
legacy block reader code available, this fix has some value still.

{code}
   void disableShortCircuit() {
+    LOG.info("Short circuit is disalbed");
     shortCircuitLocalReads = false;
   }
{code}

Spelling.

{code}
-        DFSClient.LOG.warn("Short circuit access failed ", ex);
+        DFSClient.LOG.warn("Short circuit access failed " + ex);
{code}

Hmm.  Why not print the full exception trace?
                
> When short circuit read is disallowed, DFSClient does disable short circuit 
> and fall back to regular reads
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4595
>                 URL: https://issues.apache.org/jira/browse/HDFS-4595
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 2.0.0-alpha
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>         Attachments: HDFS-4595.patch, HDFS-4595.patch
>
>
> In 1.0, when short circuit is disallowed for a user, the DFSClient disables 
> short circuit and falls back to the regular socket based reads over 
> DataTransferProtocol. In release 2.0, this fallback functionality is not 
> working.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to