[ https://issues.apache.org/jira/browse/HDFS-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603594#comment-13603594 ]
Chris Nauroth commented on HDFS-4604: ------------------------------------- +1 for the patch. I verified that the fix works on Mac and Windows. I agree with changing the logic to use {{DiskChecker}}. Thank you, Ivan. > TestJournalNode fails on Windows > -------------------------------- > > Key: HDFS-4604 > URL: https://issues.apache.org/jira/browse/HDFS-4604 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 3.0.0 > Reporter: Ivan Mitic > Assignee: Ivan Mitic > Attachments: HDFS-4604.patch > > > The test fails with the below assertion: > {code} > testFailToStartWithBadConfig(org.apache.hadoop.hdfs.qjournal.server.TestJournalNode) > Time elapsed: 209 sec <<< FAILURE! > java.lang.AssertionError: Expected to find 'is not a directory' but got > unexpected exception:java.lang.IllegalArgumentException: Journal dir > '\dev\null' should be an absolute path > at > org.apache.hadoop.hdfs.qjournal.server.JournalNode.validateAndCreateJournalDir(JournalNode.java:96) > at > org.apache.hadoop.hdfs.qjournal.server.JournalNode.start(JournalNode.java:132) > at > org.apache.hadoop.hdfs.qjournal.server.TestJournalNode.assertJNFailsToStart(TestJournalNode.java:294) > at > org.apache.hadoop.hdfs.qjournal.server.TestJournalNode.testFailToStartWithBadConfig(TestJournalNode.java:281) > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira