[ 
https://issues.apache.org/jira/browse/HDFS-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604875#comment-13604875
 ] 

Amareshwari Sriramadasu commented on HDFS-4581:
-----------------------------------------------

Some comments :
# Please take care of 80 character line indetation.
# Can you add java.nio.channels.ClosedByInterruptException also to the check? 
# Can you add the check in checkDiskError(Exception) method sothat we need not 
change in all callers? Also, you can change callers to call 
checkDiskError(Exception) instead of directly calling checkDiskError(), if it 
because of exception and not error.



                
> DataNode#checkDiskError should not be called on network errors
> --------------------------------------------------------------
>
>                 Key: HDFS-4581
>                 URL: https://issues.apache.org/jira/browse/HDFS-4581
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 1.1.1
>            Reporter: Rohit Kochar
>             Fix For: 1.2.0
>
>         Attachments: HDFS-4581-branch1.patch, HDFS-4581.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to