[
https://issues.apache.org/jira/browse/HDFS-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608366#comment-13608366
]
Chris Nauroth commented on HDFS-4584:
-------------------------------------
Hi, Arpit. This looks good. I verified it on Mac and Windows. One small
thing: instead of {{if (Path.WINDOWS) return;}}, could you use the JUnit
assertion {{assumeTrue(!Path.WINDOWS);}}? JUnit counts and reports skipped
tests differently from passing tests, and this is something that I've found
helpful for identifying if a project has any tests that are being skipped.
> Fix TestNNWithQJM failures on Windows
> -------------------------------------
>
> Key: HDFS-4584
> URL: https://issues.apache.org/jira/browse/HDFS-4584
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 3.0.0
> Environment: Windows
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Fix For: 3.0.0
>
> Attachments: HDFS-4584.1.patch, HDFS-4584.2.patch
>
>
> Multiple test cases fail in TestNNWithQJM.
> List of failing test cases:
> -
> testNewNamenodeTakesOverWriter(org.apache.hadoop.hdfs.qjournal.TestNNWithQJM):
> The process cannot access the file because another process has locked a
> portion of the file
> - testMismatchedNNIsRejected(org.apache.hadoop.hdfs.qjournal.TestNNWithQJM):
> Could not format one or more JournalNodes. 1 exceptions thrown:
> - testWebPageHasQjmInfo(org.apache.hadoop.hdfs.qjournal.TestNNWithQJM):
> Could not format one or more JournalNodes. 1 exceptions thrown:
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
