[ 
https://issues.apache.org/jira/browse/HDFS-4621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609498#comment-13609498
 ] 

Aaron T. Myers commented on HDFS-4621:
--------------------------------------

Patch looks good to me. I'm pretty confident the test failure is unrelated.

My only suggestion would be to maybe make the logging thresholds configurable, 
or a percentage of the related timeout if there is one, but you can take it or 
leave it.

+1
                
> additional logging to help diagnose slow QJM logSync
> ----------------------------------------------------
>
>                 Key: HDFS-4621
>                 URL: https://issues.apache.org/jira/browse/HDFS-4621
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ha, qjm
>    Affects Versions: 2.0.3-alpha
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hdfs-4621.txt
>
>
> I've been working on diagnosing an issue with a cluster which is seeing slow 
> logSync calls occasionally to QJM. Adding a few more pieces of logging would 
> help this:
> - in the warning messages on the client side leading up to a timeout, include 
> which nodes have responded and which ones are still pending
> - on the server side, when we actually call FileChannel.force, log a warning 
> if the sync takes longer than 1 second

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to