[ 
https://issues.apache.org/jira/browse/HDFS-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613256#comment-13613256
 ] 

Sanjay Radia commented on HDFS-4633:
------------------------------------

In the patch the 2 comments does not match the code
> +    // Forgive nodes in under 10s for this test case.
Here you changed the comment but forgot to change it again as you lowered the 
time based on Arpit's feedback.

>// [Sleeping just in case the restart of the DNs completed < 2s cause
2s is the older time, you have changed it to 5sec 
                
> TestDFSClientExcludedNodes fails sporadically if excluded nodes cache expires 
> too quickly
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-4633
>                 URL: https://issues.apache.org/jira/browse/HDFS-4633
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client, test
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>             Fix For: 3.0.0
>
>         Attachments: HDFS-4633.1.patch, HDFS-4633.2.patch
>
>
> {{TestDFSClientExcludedNodes}} simulates failures of individual data nodes in 
> the client's write pipeline and checks the client's ability to recover.  
> HDFS-4246 added support for periodic "forgiveness" by caching the list of 
> known bad data nodes with a periodic eviction.  The test uses a 1 second 
> cache expiration.  This sometimes causes failed nodes to be forgiven too fast 
> and violate the assumptions of the test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to