[
https://issues.apache.org/jira/browse/HDFS-4635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613411#comment-13613411
]
Tsz Wo (Nicholas), SZE commented on HDFS-4635:
----------------------------------------------
Some comments for LightWeightGSet.computeCapacity(..):
- For percentage parameter, I think it is better to use a double with range
[0.0, 1.0] than an int. We may call it "fraction" as well.
- The debug message "2%" below should be updated. I suggest using
StringUtils.TraditionalBinaryPrefix.long2String(..) since it is more general.
{code}
+ LightWeightGSet.LOG.debug("2% max memory = " + pcMem/(1 << 20) + " MB")
{code}
- LightWeightGSet.LOG can be replaced with LOG.
> Move BlockManager#computeCapacity to LightWeightGSet
> ----------------------------------------------------
>
> Key: HDFS-4635
> URL: https://issues.apache.org/jira/browse/HDFS-4635
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-4635.patch
>
>
> The computeCapacity in BlockManager that calculates the LightWeightGSet
> capacity as the percentage of total JVM memory should be moved to
> LightWeightGSet. This helps in other maps that are based on the GSet to make
> use of the same functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
