[
https://issues.apache.org/jira/browse/HDFS-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614572#comment-13614572
]
Kihwal Lee commented on HDFS-4581:
----------------------------------
I ran test-patch. The findbugs report is incorrect. I reran and it had exactly
same number of warnings before and after the patch.
{panel}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 416 new Findbugs
(version 1.3.9) warnings.
{panel}
+1 Everything looks okay.
> DataNode#checkDiskError should not be called on network errors
> --------------------------------------------------------------
>
> Key: HDFS-4581
> URL: https://issues.apache.org/jira/browse/HDFS-4581
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 1.1.1, 3.0.0, 0.23.7, 2.0.4-alpha
> Reporter: Rohit Kochar
> Attachments: HDFS-4581-branch1.patch, HDFS-4581-branch1.patch,
> HDFS-4581-branch1.patch, HDFS-4581-branch1.patch, HDFS-4581.patch,
> HDFS-4581.patch, HDFS-4581.patch, HDFS-4581.patch, HDFS-4581.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
