[ 
https://issues.apache.org/jira/browse/HDFS-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615587#comment-13615587
 ] 

Jing Zhao commented on HDFS-4611:
---------------------------------

The current patch looks good. Only one question: while loading the fsimage, 
when a referred inode (i.e., the inode that has been renamed in history) is 
loaded, some of the snapshots associated with its diffs may not have been 
loaded from the fsimage yet, since snapshots are loaded while we load the 
corresponding INodeDirectorySnapshottable. Maybe we need to load all the 
snapshots (by going through all the snapshottable directories) in the very 
beginning without setting the root's parent, and revisit these snapshots when 
we load the corresponding snapshottable directories?
                
> Snapshot: Update FSImage for INodeReference
> -------------------------------------------
>
>                 Key: HDFS-4611
>                 URL: https://issues.apache.org/jira/browse/HDFS-4611
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4611_20130320.patch, h4611_20130325.patch, 
> h4611_20130327.patch
>
>
> INodeReference is added for supporting rename with snapshot.  FSImage needs 
> to be changed to store INodeReference.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to