[ 
https://issues.apache.org/jira/browse/HDFS-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617547#comment-13617547
 ] 

Lohit Vijayarenu commented on HDFS-2843:
----------------------------------------

Isn't this considered incompatible change?
{code}
-  required StorageInfoProto storageInfo = 3;  // Node information
+  required NodeInfoProto nodeInfo = 3;  // Node information
{code}
Protobuf suggest you add newer elements, but I also see that StorageInfoProto 
was already declared as required. I do not understand how would this affect on 
disk format vs newer code reading it, but it sure looks like incompatible 
change.
                
> Rename protobuf message StorageInfoProto to NodeInfoProto
> ---------------------------------------------------------
>
>                 Key: HDFS-2843
>                 URL: https://issues.apache.org/jira/browse/HDFS-2843
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>         Attachments: HDFS-2843.patch
>
>
> StorageInfoProto has cTime, layoutVersion, namespaceID and clusterID. This is 
> really information of a node that is part of the cluster, such as Namenode, 
> Standby/Secondary/Backup/Checkpointer and datanodes. To reflect this, I want 
> to rename it as NodeInfoProto from StorageInfoProto.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to