[
https://issues.apache.org/jira/browse/HDFS-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627353#comment-13627353
]
Suresh Srinivas edited comment on HDFS-4679 at 4/10/13 1:28 AM:
----------------------------------------------------------------
In this patch, along with the suggested changes in description, I fixed the
following issues I found:
# FSNamesystem#setTimes does not check for safemode and throw SafemodeException.
# FSNamesystem#createSymlinkInt did not check for safemode and throw
SafemodeException
The test failure is due to my patch adding check for safemode in
FSNamesystem#setTimes.
Was there any reason why FSNamesystem#setTimes() write operation does not check
for safemode? Given the lack of comments I will assume that it is a bug.
was (Author: sureshms):
In this patch, along with the suggested changes in description, I found an
issue where FSNamesystem#setTimes was not checking for safemode and throwing
SafemodeException. The test failure is due to my patch adding check for
safemode.
Was there any reason why FSNamesystem#setTimes() write operation does not check
for safemode? Given the lack of comments I will assume that it is a bug.
> Namenode operation checks should be done in a consistent manner
> ---------------------------------------------------------------
>
> Key: HDFS-4679
> URL: https://issues.apache.org/jira/browse/HDFS-4679
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-4679.patch
>
>
> Different operations performs checks in different order. I propose
> consistently checking the following in namenode operations:
> # Print debug log related to the operation
> # validate the input parameters, file names
> # Grab read or write lock
> #* check if system is ready for read or write operation
> #* check if system is in safemode (for write operations)
> #* check permissions to see if the user is owner, has access or is super user
> privileges
> # Release the lock
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
