[
https://issues.apache.org/jira/browse/HDFS-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627420#comment-13627420
]
Hadoop QA commented on HDFS-4679:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12577937/HDFS-4679.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4213//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4213//console
This message is automatically generated.
> Namenode operation checks should be done in a consistent manner
> ---------------------------------------------------------------
>
> Key: HDFS-4679
> URL: https://issues.apache.org/jira/browse/HDFS-4679
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-4679.patch, HDFS-4679.patch
>
>
> Different operations performs checks in different order. I propose
> consistently checking the following in namenode operations:
> # Print debug log related to the operation
> # validate the input parameters, file names
> # Grab read or write lock
> #* check if system is ready for read or write operation
> #* check if system is in safemode (for write operations)
> #* check permissions to see if the user is owner, has access or is super user
> privileges
> # Release the lock
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
