[
https://issues.apache.org/jira/browse/HDFS-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628486#comment-13628486
]
Sanjay Radia commented on HDFS-4434:
------------------------------------
+1 with the following feedback
* I would like to not-allow symlinks to contain /.reserved in this jira- we
should discuss adding this in separate jira. I see /.reserved as veneer and
allowing it in symlinks makes it much more than a veneer.
* addChild - the check for /.reserved - add comment that this can happen only
via the editsLog during an upgrade OR if user is creating /.reserved
* create a jira to not allow .reserved anywhere in the namespace
* FSDirectory - you have added fileNotFoundException in a few places where it
is not needed.
* FSDirectory#addToInodeMap FSDirectory#removeFromInodeMap - suggestion - add
suffix "Unprotected"? (over time we should we change "internal" to unprotected)
* Suggestion - given that you are reserving 10 bits why not go a little
further and reserve 14bits -- don't have any use cases right now.
* TestFsDirectory
** Your new tests do not use the setup/teardown that the other tests do - add
a comment or move the new tests to a new file TestFsDirectory2.
** rename getInodes to something like createTreeOfInodes
Nice clean patch. Thanks.
> Provide a mapping from INodeId to INode
> ---------------------------------------
>
> Key: HDFS-4434
> URL: https://issues.apache.org/jira/browse/HDFS-4434
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Suresh Srinivas
> Attachments: HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch,
> HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch,
> HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch,
> HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch,
> HDFS-4434.patch, HDFS-4434.patch
>
>
> This JIRA is to provide a way to access the INode via its id. The proposed
> solution is to have an in-memory mapping from INodeId to INode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
