[ 
https://issues.apache.org/jira/browse/HDFS-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631918#comment-13631918
 ] 

Colin Patrick McCabe commented on HDFS-4695:
--------------------------------------------

Looks good to me.

In this case:
{code}
+      for (EditLogInputStream stream : streams) {
+        IOUtils.closeStream(stream);
+      }
{code}

You should be able to use {{IOUtils.closeQuietly}} or similar.  
{{EditLogInputStream}} implements {{Closeable}}.
                
> TestEditLog leaks open file handles between tests
> -------------------------------------------------
>
>                 Key: HDFS-4695
>                 URL: https://issues.apache.org/jira/browse/HDFS-4695
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Ivan Mitic
>            Assignee: Ivan Mitic
>         Attachments: HDFS-4695.patch
>
>
> The test leaks open file handles causing subsequent test cases to fail on 
> Windows (common cross-platform issue we've seen multiple times so far).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to