[ 
https://issues.apache.org/jira/browse/HDFS-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633395#comment-13633395
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4700:
----------------------------------------------

The patch looks good.  My only concern is that the reference count seems not 
being updated in undo.

Also why add verify to addSpaceConsumed?  Is it for quota check?

                
> Fix the undo section of rename with snapshots
> ---------------------------------------------
>
>                 Key: HDFS-4700
>                 URL: https://issues.apache.org/jira/browse/HDFS-4700
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4700.000.patch, HDFS-4700.001.patch
>
>
> If a rename operation fails in the middle, the current undo section does not 
> clear the diff list. This jira aims to fix the undo logic and adds 
> corresponding unit tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to