[
https://issues.apache.org/jira/browse/HDFS-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635139#comment-13635139
]
Hudson commented on HDFS-4707:
------------------------------
Integrated in Hadoop-Hdfs-Snapshots-Branch-build #161 (See
[https://builds.apache.org/job/Hadoop-Hdfs-Snapshots-Branch-build/161/])
HDFS-4707. Add snapshot methods to FilterFileSystem and fix findbugs
warnings. (Revision 1469119)
Result = FAILURE
szetszwo :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1469119
Files :
*
/hadoop/common/branches/HDFS-2802/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
*
/hadoop/common/branches/HDFS-2802/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFilterFileSystem.java
*
/hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-2802.txt
*
/hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java
*
/hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java
*
/hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/Snapshot.java
*
/hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotFSImageFormat.java
> Fix FilterFileSystem and findbugs warning in Snapshot branch
> ------------------------------------------------------------
>
> Key: HDFS-4707
> URL: https://issues.apache.org/jira/browse/HDFS-4707
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: Snapshot (HDFS-2802)
>
> Attachments: h4707_20130417.patch
>
>
> The snapshot methods are not added to FilterFileSystem.
> Findbugs warnings:
> - SIC Should snapshot.Snapshot$Root be a _static_ inner class?
> - WMI Method FSImageFormat$Saver.saveImage(ByteBuffer,
> INodeDirectory, DataOutputStream, Snapshot, boolean) makes inefficient use of
> keySet iterator instead of entrySet iterator
> - BC Unchecked/unconfirmed cast from
> FSImageSerialization.writeINodeFile(INodeFile, DataOutput, boolean)
> - BC Unchecked/unconfirmed cast from
> snapshot.SnapshotFSImageFormat.loadDirectoryDiffList(INodeDirectory,
> DataInput, FSImageFormat$Loader)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira