[
https://issues.apache.org/jira/browse/HDFS-4705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637461#comment-13637461
]
Chris Nauroth commented on HDFS-4705:
-------------------------------------
+1 for the patch. The code looks good. I tested successfully on both Mac and
Windows.
{quote}
-1 core tests. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.qjournal.client.TestQuorumJournalManager
{quote}
This appears to be unrelated. I couldn't repro. Perhaps it's a flaky test?
Ivan, thank you very much for tracking down these test failures and putting
together a complete patch.
> Address HDFS test failures on Windows because of invalid dfs.namenode.name.dir
> ------------------------------------------------------------------------------
>
> Key: HDFS-4705
> URL: https://issues.apache.org/jira/browse/HDFS-4705
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Priority: Minor
> Attachments: HDFS-4705.1.patch, HDFS-4705.2.patch
>
>
> Test fails on Windows with the below exception:
> {code}
> testFormatShouldBeIgnoredForNonFileBasedDirs(org.apache.hadoop.hdfs.server.namenode.TestAllowFormat)
> Time elapsed: 49 sec <<< ERROR!
> java.io.IOException: No image directories available!
> at
> org.apache.hadoop.hdfs.server.namenode.FSImage.saveFSImageInAllDirs(FSImage.java:912)
> at
> org.apache.hadoop.hdfs.server.namenode.FSImage.saveFSImageInAllDirs(FSImage.java:905)
> at
> org.apache.hadoop.hdfs.server.namenode.FSImage.format(FSImage.java:151)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNode.format(NameNode.java:758)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNode.format(NameNode.java:259)
> at
> org.apache.hadoop.hdfs.server.namenode.TestAllowFormat.testFormatShouldBeIgnoredForNonFileBasedDirs(TestAllowFormat.java:181)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
