[
https://issues.apache.org/jira/browse/HDFS-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638359#comment-13638359
]
Tsz Wo (Nicholas), SZE commented on HDFS-4719:
----------------------------------------------
Thanks Arpit. The patch looks good. Two minor comments:
- Please also move the javadoc of createDiff and createSnapshotCopy from
Factory to AbstractINodeDiffList.
- The new file FileDiffList.java needs license header.
> Minor simplifications to snapshot code
> --------------------------------------
>
> Key: HDFS-4719
> URL: https://issues.apache.org/jira/browse/HDFS-4719
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: Snapshot (HDFS-2802)
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Fix For: Snapshot (HDFS-2802)
>
> Attachments: HDFS-4719.002.patch, HDFS-4719.003.patch
>
>
> Remove couple of unused snapshot functions and factor away the factory
> classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
