[
https://issues.apache.org/jira/browse/HDFS-4739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640826#comment-13640826
]
Hadoop QA commented on HDFS-4739:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12580322/HDFS-4739.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.TestNNStorageRetentionManager
org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
org.apache.hadoop.hdfs.server.namenode.TestNNStorageRetentionFunctional
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4307//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4307//console
This message is automatically generated.
> NN can miscalculate the number of extra edit log segments to retain
> -------------------------------------------------------------------
>
> Key: HDFS-4739
> URL: https://issues.apache.org/jira/browse/HDFS-4739
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.0.4-alpha
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Attachments: HDFS-4739.patch
>
>
> The code in NNStorageRetentionManager#purgeOldStorage is intended to place a
> cap on the number of _extra_ edit log segments retained beyond what is
> strictly required to replay the FS history since the last fsimage. In fact
> this code currently places a limit on the _total_ number of extra edit log
> segments. If the number of required segments is greater than the configured
> cap, there will be no data loss, but an ugly error will be thrown and the NN
> will fail to start.
> The fix is simple, and in the meantime a work-around is just to raise the
> value of dfs.namenode.max.extra.edits.segments.retained and start the NN.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
