[
https://issues.apache.org/jira/browse/HDFS-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643398#comment-13643398
]
Chris Nauroth commented on HDFS-4768:
-------------------------------------
{quote}
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}
There are no new tests, but this patch is required to get consistent successful
runs for {{TestDeleteBlockPool}}. I ran the test repeatedly with this patch on
multiple platforms, and it passed every time.
> block scanner does not close verification log when a block pool is being
> deleted (but the datanode remains running)
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-4768
> URL: https://issues.apache.org/jira/browse/HDFS-4768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 3.0.0, 2.0.4-alpha
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HDFS-4768.1.patch
>
>
> HDFS-4274 fixed a file handle leak of the block scanner's verification logs
> by adding method {{BlockPoolSliceScanner#shutdown}} and guaranteeing that the
> method gets called for each live {{BlockPoolSliceScanner}} during datanode
> shutdown. However, that patch did not consider the case of deleting a block
> pool via {{ClientDatanodeProtocol#deleteBlockPool}} while the datanode
> remains running.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
