[ 
https://issues.apache.org/jira/browse/HDFS-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643519#comment-13643519
 ] 

Ivan Mitic commented on HDFS-4610:
----------------------------------

Thanks Chris and Arpit for the review and comments.

bq. I do see that this patch is making changes in TestCheckpoint and 
TestNNStorageRetentionFunctional though. Ivan, can you clarify if this patch 
makes these 2 tests pass for you?
Thanks, let me take a look. I did not explicitly try to debug every unittest I 
changed that was already failing. My main goal was to add the missing 
functionality for Windows and set us up for the better cross platform support. 
                
> Move to using common utils FileUtil#setReadable/Writable/Executable and 
> FileUtil#canRead/Write/Execute
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4610
>                 URL: https://issues.apache.org/jira/browse/HDFS-4610
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Ivan Mitic
>            Assignee: Ivan Mitic
>         Attachments: HDFS-4610.commonfileutils.2.patch, 
> HDFS-4610.commonfileutils.patch
>
>
> Switch to using common utils described in HADOOP-9413 that work well 
> cross-platform.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to