[
https://issues.apache.org/jira/browse/HDFS-4578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643818#comment-13643818
]
Tsz Wo (Nicholas), SZE commented on HDFS-4578:
----------------------------------------------
Patch looks good. Some nits
- Use upper case letters for snapshotIdBitWidth since it is static.
- Change getMaxSnapshotID() to a constant MAX_SNAPSHOT_ID.
> Restrict snapshot IDs to 24-bits wide
> -------------------------------------
>
> Key: HDFS-4578
> URL: https://issues.apache.org/jira/browse/HDFS-4578
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: Snapshot (HDFS-2802)
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Fix For: Snapshot (HDFS-2802)
>
> Attachments: HDFS-4578.patch, HDFS-4578.patch, HDFS-4578.patch
>
>
> Snapshot IDs will be restricted to 24-bits. This will allow at the most
> ~16Million snapshots globally.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
