[ 
https://issues.apache.org/jira/browse/HDFS-4578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HDFS-4578:
--------------------------------

    Attachment: HDFS-4578.004.patch

Thanks for the feedback Nicholas.

{quote}
Use upper case letters for snapshotIdBitWidth since it is static.
{quote}
Fixed.


{quote}
Change getMaxSnapshotID() to a constant MAX_SNAPSHOT_ID.
{quote}
The method allows testing the limit with a mock object without creating 2^^24 
snapshots in TestSnapshotManager.

I also resolved a few merge conflicts.
                
> Restrict snapshot IDs to 24-bits wide
> -------------------------------------
>
>                 Key: HDFS-4578
>                 URL: https://issues.apache.org/jira/browse/HDFS-4578
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: Snapshot (HDFS-2802)
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>             Fix For: Snapshot (HDFS-2802)
>
>         Attachments: HDFS-4578.004.patch, HDFS-4578.patch, HDFS-4578.patch, 
> HDFS-4578.patch
>
>
> Snapshot IDs will be restricted to 24-bits. This will allow at the most 
> ~16Million snapshots globally.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to