[ 
https://issues.apache.org/jira/browse/HDFS-4712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644406#comment-13644406
 ] 

andrea manzi commented on HDFS-4712:
------------------------------------

Hi Colin,
thanks a lot for your comments and for the tips they were really useful and now 
my code looks better. ( i hope:-)) 
2 things:
1) i have kept the signature with numEntries in the hdfsFreeDataNodeInfo 
method, cause i aligned the method to hdfsFreeFileInfo. But i can also remove 
the parameter and use a null pointer as you suggested
2) i added a method (enum_to_string) to convert the enum value to a string, 
cause in the generation of the enumtype trough JNI to pass as parameter to 
getDataNodeStats, i need the string associated to the enum value. 

i have also created a patch as described in the wiki and attached to the ticket

thanks again
Andrea

                
> New libhdfs method hdfsGetDataNodes
> -----------------------------------
>
>                 Key: HDFS-4712
>                 URL: https://issues.apache.org/jira/browse/HDFS-4712
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: libhdfs
>            Reporter: andrea manzi
>         Attachments: HDFS-4712.patch, hdfs.c.diff, hdfs.h.diff
>
>
> we have implemented a possible extension to libhdfs to retrieve information 
> about the available datanodes ( there was a mail on the hadoop-hdsf-dev 
> mailing list initially abut this :
> http://mail-archives.apache.org/mod_mbox/hadoop-hdfs-dev/201204.mbox/%3CCANhO-
> s0mvororrxpjnjbql6brkj4c7l+u816xkdc+2r0whj...@mail.gmail.com%3E)
> i would like to know how to proceed to create a patch, cause on the wiki 
> http://wiki.apache.org/hadoop/HowToContribute i can see info about JAVA 
> patches but nothing related to extensions in C.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to