[
https://issues.apache.org/jira/browse/HDFS-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645142#comment-13645142
]
Aaron T. Myers commented on HDFS-4751:
--------------------------------------
Though I think you've correctly identified the issue, I'm not sure that this
patch will definitely address it, since it looks to me like the
{{isFilesBeingWrittenEmpty}} isn't synchronized on DFSClient. Please let me
know if I'm missing something.
> TestLeaseRenewer#testThreadName flakes
> --------------------------------------
>
> Key: HDFS-4751
> URL: https://issues.apache.org/jira/browse/HDFS-4751
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 3.0.0, 2.0.5-beta
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Priority: Minor
> Attachments: hdfs-4751-1.patch
>
>
> Seen internally and during upstream trunk builds, error like the following:
> {noformat}
> Error Message:
> Unfinished stubbing detected here: -> at
> org.apache.hadoop.hdfs.TestLeaseRenewer.testThreadName(TestLeaseRenewer.java:197)
> E.g. thenReturn() may be missing. Examples of correct stubbing:
> when(mock.isOk()).thenReturn(true);
> when(mock.isOk()).thenThrow(exception);
> doThrow(exception).when(mock).someVoidMethod(); Hints: 1. missing
> thenReturn() 2. although stubbed methods may return mocks, you cannot inline
> mock creation (mock()) call inside a thenReturn method (see issue 53)
> Stack Trace:
> org.mockito.exceptions.misusing.UnfinishedStubbingException:
> Unfinished stubbing detected here:
> -> at
> org.apache.hadoop.hdfs.TestLeaseRenewer.testThreadName(TestLeaseRenewer.java:197)
> {noformat}
> I believe it's due to mocking while being concurrently accessed by another
> thread.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
