[ 
https://issues.apache.org/jira/browse/HDFS-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13648124#comment-13648124
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4791:
----------------------------------------------

- Is it true that two withName objects could possibly have the same 
lastSnapshotId?  If yes, WITHNAME_COMPARATOR may consider two different 
withName objects the same in getPriorWithName(..).  Also, the changes in 
WithCount.addReference/removeReference are incorrect.

- The dstSnapshotId in WithName is not useful.

- In getPriorWithName(..) and getSelfSnapshot(), use 
AbstractINodeDiffList.getDiffById(..) to find snapshot.
                
> Update and fix deletion of reference inode
> ------------------------------------------
>
>                 Key: HDFS-4791
>                 URL: https://issues.apache.org/jira/browse/HDFS-4791
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4791.000.patch, HDFS-4791.001.patch
>
>
> Currently for deleting or destroying a reference node, we directly call the 
> corresponding methods of the referred inode, and patch code for extra clean 
> after deletion. This jira will revisit the deletion of reference inodes, 
> simplify the current code and fix existing bugs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to