[
https://issues.apache.org/jira/browse/HDFS-4491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Lowe updated HDFS-4491:
-----------------------------
Status: Open (was: Patch Available)
Thanks for working on this, Andrey. The patch no longer applies to trunk,
could you refresh it? Also the release audit warning is legit, PathUtils.java
is missing the license header.
Some additional comments from a quick run-through of the diffs:
* MiniDFSCluster has a potentially incompatible change for subclasses as
determineDfsBaseDir was removed. Have you verified HBase, Hive, and Pig tests
will not be broken by this change?
* The implicit shared namespace between tests calling setIpcPort is a bit less
than ideal from a maintenance perspective, as one would need to search through
all the tests to see if a particular hardcoded port might be used by another
test and therefore occasionally break parallel testing. Maybe a utility that
dynamically allocates ports via file locks would be better for those cases if
ephemeral ports cannot be used?
* Nit: for the openConnection timeout support, rather than having an Integer
and a null check, I think it'd be cleaner to just have an int parameter and
leave the DEFAULT_SOCKET_TIMEOUT in URLUtils public. That way the methods
without a timeout simply pass URLUtils.DEFAULT_SOCKET_TIMEOUT to the method
that supports a timeout, and the latter method doesn't need a conditional. Not
a required change, I just thought it'd be a bit cleaner.
> Parallel testing HDFS
> ---------------------
>
> Key: HDFS-4491
> URL: https://issues.apache.org/jira/browse/HDFS-4491
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 3.0.0
> Reporter: Tsuyoshi OZAWA
> Assignee: Andrey Klochkov
> Attachments: HDFS-4491--n2.patch, HDFS-4491--n3.patch,
> HDFS-4491--n4.patch, HDFS-4491--n5.patch, HDFS-4491--n6.patch,
> HDFS-4491--n7.patch, HDFS-4491--n8.patch, HDFS-4491.patch
>
>
> Parallel execution of HDFS tests in multiple forks. See HADOOP-9287 for
> details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
