[
https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652251#comment-13652251
]
Aaron T. Myers commented on HDFS-4698:
--------------------------------------
Latest patch looks pretty good to me. Two comments, one question:
# Recommend you move the comments for totalBytesRead, totalLocalBytesRead, etc.
from the member variables to the methods, and make them proper javadocs. That
way people who are programming against this API in IDEs will see the comments
when calling these methods, rather than having to look at the code for the
private member variables.
# In the test, recommend you use the JUnit Assume feature, instead of returning
early in the event the domain socket didn't load, so that the test shows up
properly as having been skipped in maven runs.
# Any thoughts about adding this to the libhdfs API as well? Could certainly do
that in a separate JIRA, if you'd like.
> provide client-side metrics for remote reads, local reads, and short-circuit
> reads
> ----------------------------------------------------------------------------------
>
> Key: HDFS-4698
> URL: https://issues.apache.org/jira/browse/HDFS-4698
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
> Affects Versions: 2.0.4-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch,
> HDFS-4698.003.patch
>
>
> We should provide metrics to let clients know how many bytes of data they
> have read remotely, versus locally or via short-circuit local reads. This
> will allow clients to know how well they're doing at bringing the computation
> to the data, which will be useful in evaluating placement policies and
> cluster configurations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
