[ 
https://issues.apache.org/jira/browse/HDFS-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aaron T. Myers updated HDFS-4830:
---------------------------------

    Attachment: HDFS-4830.patch

Here's a patch which fixes the issue. It also takes the liberty of changing the 
actual setting name from ".percent" to ".fraction" per [~tlipcon]'s suggestion 
in [this 
comment|https://issues.apache.org/jira/browse/HDFS-4804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653282#comment-13653282].
 Given that there's so far no release which includes this feature, there's no 
need to add a deprecation for the old setting name.
                
> Typo in config settings for AvailableSpaceVolumeChoosingPolicy in 
> hdfs-default.xml
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-4830
>                 URL: https://issues.apache.org/jira/browse/HDFS-4830
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.0.5-beta
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Minor
>         Attachments: HDFS-4830.patch
>
>
> In hdfs-default.xml we have these two settings:
> {noformat}
> dfs.datanode.fsdataset.volume.choosing.balanced-space-threshold
> dfs.datanode.fsdataset.volume.choosing.balanced-space-preference-percent
> {noformat}
> But in fact they should be these, from DFSConfigKeys.java:
> {noformat}
> dfs.datanode.available-space-volume-choosing-policy.balanced-space-threshold
> dfs.datanode.available-space-volume-choosing-policy.balanced-space-preference-percent
> {noformat}
> This won't actually affect any functionality, since default values are used 
> in the code anyway, but makes the documentation generated from 
> hdfs-default.xml inaccurate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to