[ 
https://issues.apache.org/jira/browse/HDFS-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665617#comment-13665617
 ] 

Jing Zhao commented on HDFS-4840:
---------------------------------

Thanks for the fix Kihwal! Your analysis makes sense to me. The NPE here is 
thrown during the shutdown (NN waited 3 seconds for the interruption of 
replication monitor), while the NPE in HDFS-4813 was thrown before the shutdown 
(there was no 3 seconds waiting time in the log).

The patch looks good to me. +1 for the patch.
                
> ReplicationMonitor gets NPE during shutdown
> -------------------------------------------
>
>                 Key: HDFS-4840
>                 URL: https://issues.apache.org/jira/browse/HDFS-4840
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0, 2.0.5-beta
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>         Attachments: HDFS-4840.patch.txt
>
>
> TestBlocksWithNotEnoughRacks occasionally fails during test tear down because 
> RaplicationMonitor gets NPE.
> Seen at https://builds.apache.org/job/Hadoop-Hdfs-trunk/1406/.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to