[
https://issues.apache.org/jira/browse/HDFS-4491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13666599#comment-13666599
]
Andrey Klochkov commented on HDFS-4491:
---------------------------------------
[~jlowe], thanks for the feedback. I'm refreshing the patch. To your questions:
- Yes, I verified that removal of determineDfsBaseDir doesn't introduce
problems in HBase, Hive and Pig
- Agree that it'd be great to have a common mechanism of allocating ports
dynamically, but it's not just setIpcPort, there are many other places. Still
I'd say hardcoding port numbers is used pretty rarely and most of the chance of
overlapping is small, so I'd vote for just introducing a guideline for checking
port numbers if hardcoded ports are used in a test, instead of automating it.
- Reworked this part a bit transforming URLUtils into URLConnectionFactory,
thus encapsulating timeout handling into it and allowing tests to override the
default factory in WebHdfsFileSystem and HftpFileSystem. So there are no
additional methods with the timeout parameter anymore, and no null checks as
well. Please take a look.
> Parallel testing HDFS
> ---------------------
>
> Key: HDFS-4491
> URL: https://issues.apache.org/jira/browse/HDFS-4491
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 3.0.0
> Reporter: Tsuyoshi OZAWA
> Assignee: Andrey Klochkov
> Attachments: HDFS-4491--n2.patch, HDFS-4491--n3.patch,
> HDFS-4491--n4.patch, HDFS-4491--n5.patch, HDFS-4491--n6.patch,
> HDFS-4491--n7.patch, HDFS-4491--n8.patch, HDFS-4491.patch
>
>
> Parallel execution of HDFS tests in multiple forks. See HADOOP-9287 for
> details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
