[ 
https://issues.apache.org/jira/browse/HDFS-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682772#comment-13682772
 ] 

Chris Nauroth commented on HDFS-4845:
-------------------------------------

Would you mind putting the unlock call behind a finally block?  Technically, 
it's not really required.  I don't see any checked exceptions that can get in 
the way right now, but if the code evolves to something more complex, then it 
could be easy to forget adding the finally block later.  Also, using a finally 
block would be consistent with the other call sites that acquire/release the 
lock.
                
> FSEditLogLoader gets NPE while accessing INodeMap in TestEditLogRace
> --------------------------------------------------------------------
>
>                 Key: HDFS-4845
>                 URL: https://issues.apache.org/jira/browse/HDFS-4845
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Kihwal Lee
>            Assignee: Arpit Agarwal
>            Priority: Critical
>         Attachments: HDFS-4845.001.patch, HDFS-4845.002.patch, 
> HDFS-4845.003.patch, HDFS-4845.004.patch
>
>
> TestEditLogRace fails occasionally because it gets NPE from manipulating 
> INodeMap while loading edits.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to