[ 
https://issues.apache.org/jira/browse/HDFS-4875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683659#comment-13683659
 ] 

Jing Zhao commented on HDFS-4875:
---------------------------------

Thanks for adding the test, Arpit! The patch looks good to me. Only one minor 
nit: the RANDOM field can be removed because it has not been used.
                
> Add a test for testing snapshot file length
> -------------------------------------------
>
>                 Key: HDFS-4875
>                 URL: https://issues.apache.org/jira/browse/HDFS-4875
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: snapshots, test
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Arpit Agarwal
>            Priority: Minor
>         Attachments: HDFS-4875.001.patch
>
>
> Here is a test idea from Suresh:
> - A file was length x at the time of snapshot (say s1) creation
> - Later y bytes get added to the file through append
> When client gets block locations for the file from snapshot s1, the length it 
> know is x. We should make sure it cannot read beyond length x.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to