[
https://issues.apache.org/jira/browse/HDFS-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688591#comment-13688591
]
Konstantin Shvachko commented on HDFS-4883:
-------------------------------------------
Looking good. Few comments.
# The proto definition for fileId should be optional, looking like
{code}optional uint64 fileId = 4 [default = 0];{code}
it should be the last to match the parameters with the fields ordering.
# In NameNodeRpcServer.complete() one line is longer than 80.
# Please remove unrelated typo fix in FSNamesystem() constructor.
# It would be good to add a test case in one of the existing tests, which
confirms the fileId is actually checked and an exception is thrown.
> complete() should verify fileId
> -------------------------------
>
> Key: HDFS-4883
> URL: https://issues.apache.org/jira/browse/HDFS-4883
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.1.0-beta
> Reporter: Konstantin Shvachko
> Assignee: Tao Luo
> Attachments: HDFS-4883.patch
>
>
> It seems inconsistent that complete() avoids verifying real fileId, while
> addBlock() does it meticulously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
