[ 
https://issues.apache.org/jira/browse/HDFS-4762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13690378#comment-13690378
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4762:
----------------------------------------------

Some questions/comments so far:

- Nfs3 extends Nfs3Base and Mountd extends MountdBase but the subclass does not 
override anything.  Do we really need the base classes and the subclasses?  Are 
you going to add more code in the subclasses?

- Does OpenFileCtx.nonSequentialWriteInMemory need to be synchronized?  Also, 
in updateNonSequentialWriteInMemory(..), I think we should check the parameter 
before "nonSequentialWriteInMemory += count".  Otherwise, 
nonSequentialWriteInMemory may become negative and the OpenFileCtx object 
becomes unusable.

- Remove "throws IOException" from OpenFileCtx.getFlushedOffset().

                
> Provide HDFS based NFSv3 and Mountd implementation
> --------------------------------------------------
>
>                 Key: HDFS-4762
>                 URL: https://issues.apache.org/jira/browse/HDFS-4762
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HDFS-4762.patch
>
>
> This is to track the implementation of NFSv3 to HDFS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to