[
https://issues.apache.org/jira/browse/HDFS-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693393#comment-13693393
]
Chris Nauroth commented on HDFS-4932:
-------------------------------------
Hi, Fengdong. The patch looks good. A couple of minor comments:
# Can you please add a comment stating that this code inserts a line break
every 3 entries to prevent very wide lines?
# Minor style issue for each of the following lines: can you please add a space
before opening braces? Also, can you please add a space after {{for}}?
{code}
if (null != manager){
{code}
{code}
for(int i = 0; i < managers.length; ++i){
{code}
{code}
if (i < managers.length - 1){
{code}
{code}
if ((i+1) % 3 == 0){
{code}
{quote}
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}
I think this is OK if manual testing was done. You'd have to do a lot of
awkward deep mocking to be able to call this method from a test, so it's
probably not worth it.
> Avoid a long line on the name node webUI if we have more Journal nodes
> ----------------------------------------------------------------------
>
> Key: HDFS-4932
> URL: https://issues.apache.org/jira/browse/HDFS-4932
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ha, namenode
> Reporter: Fengdong Yu
> Assignee: Fengdong Yu
> Priority: Minor
> Fix For: 2.1.0-beta
>
> Attachments: HDFS-4932.patch
>
>
> If we have more Journal nodes, It shows a long line on the name node webUI,
> this patch wrapped line. just show three journal nodes on each line. I don't
> change CSS because I don't want to affect other related web styles.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
