[
https://issues.apache.org/jira/browse/HDFS-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696140#comment-13696140
]
Hadoop QA commented on HDFS-4797:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12583032/h4797_20130513b.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4580//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4580//console
This message is automatically generated.
> BlockScanInfo does not override equals(..) and hashCode() consistently
> ----------------------------------------------------------------------
>
> Key: HDFS-4797
> URL: https://issues.apache.org/jira/browse/HDFS-4797
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h4797_20130513b.patch, h4797_20130513.patch
>
>
> In the code below, equals(..) compares lastScanTime but hashCode() is
> computed using block ID. Therefore, it could have two BlockScanInfo objects
> which are equal but have two different hash codes.
> {code}
> //BlockScanInfo
> @Override
> public int hashCode() {
> return block.hashCode();
> }
>
> @Override
> public boolean equals(Object other) {
> return other instanceof BlockScanInfo &&
> compareTo((BlockScanInfo)other) == 0;
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
