[
https://issues.apache.org/jira/browse/HDFS-4762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13697557#comment-13697557
]
Brandon Li commented on HDFS-4762:
----------------------------------
{quote}OffsetRange.compareTo(..) only compares min....{quote}
Thanks!
{quote} The second if-statement should be "if (!dumpFile.createNewFile())".
Also, createNewFile() ensures that the file does not exist. So the first
if-statement may not be needed.{quote}
I removed "if (!dumpFile.createNewFile())" since "dumpOut = new
FileOutputStream(dumpFile);" already created the file.
{quote}Is it okay to return when there is an exception? Should it re-throws the
exception?{quote}
Any error will disable file dump. Even it re-throws the exception, the caller
so far doesn't have extra handling to do.
{quote} WriteManager.shutdownAsyncDataService() is not used.{quote}
I will create a JIRA to add shutdown procedures which will use this method.
> Provide HDFS based NFSv3 and Mountd implementation
> --------------------------------------------------
>
> Key: HDFS-4762
> URL: https://issues.apache.org/jira/browse/HDFS-4762
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-4762.patch, HDFS-4762.patch.2, HDFS-4762.patch.3,
> HDFS-4762.patch.3, HDFS-4762.patch.4, HDFS-4762.patch.5, HDFS-4762.patch.6
>
>
> This is to track the implementation of NFSv3 to HDFS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
