[
https://issues.apache.org/jira/browse/HDFS-4912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706754#comment-13706754
]
Hadoop QA commented on HDFS-4912:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12591808/HDFS-4912.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4641//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4641//console
This message is automatically generated.
> Cleanup FSNamesystem#startFileInternal
> --------------------------------------
>
> Key: HDFS-4912
> URL: https://issues.apache.org/jira/browse/HDFS-4912
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-4912.1.patch, HDFS-4912.2.patch, HDFS-4912.patch
>
>
> FSNamesystem#startFileInternal is used by both create and append. This
> results in ugly if else conditions to consider append/create scenarios. This
> method can be refactored and the code can be cleaned up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
