[ 
https://issues.apache.org/jira/browse/HDFS-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712801#comment-13712801
 ] 

Arpit Agarwal commented on HDFS-4996:
-------------------------------------

+1 for the patch.

Built and ran TestMetaSave on OS X and Windows.
                
> ClientProtocol#metaSave can be made idempotent by overwriting the output file 
> instead of appending to it
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4996
>                 URL: https://issues.apache.org/jira/browse/HDFS-4996
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Minor
>         Attachments: HDFS-4996.1.patch, HDFS-4996.2.patch
>
>
> {{ClientProtocol#metaSave}} opens its output file for append.  This prevents 
> the operation from being idempotent, because retries can cause unpredictable 
> side effects (single copy of the output vs. multiple copies).  As discussed 
> on HDFS-4974, the operation could be made idempotent by changing this to open 
> the file for overwrite instead of append.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to