[
https://issues.apache.org/jira/browse/HDFS-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718913#comment-13718913
]
Jing Zhao commented on HDFS-5024:
---------------------------------
The new patch looks pretty good to me. Only a very minor issue:
{code}
+ LOG.debug("Block (=" + lastblock + ") not found");
+ return;
{code}
Maybe we can add a "if (LOG.isDebugEnabled())" check here?
+1 after the change.
> Make createCommitBlockSynchronization idempotent
> ------------------------------------------------
>
> Key: HDFS-5024
> URL: https://issues.apache.org/jira/browse/HDFS-5024
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 3.0.0, 2.1.0-beta
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Attachments: HDFS-5024.001.patch, HDFS-5024.002.patch,
> HDFS-5024.003.patch, HDFS-5024.004.patch, HDFS-5024.005.patch
>
>
> commitBlockSynchronization is not idempotent (repeated invocations with the
> same arguments will throw an exception). By making it Idempotent we can
> remove the requirement to track invocations using the retry cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
