[ 
https://issues.apache.org/jira/browse/HDFS-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738310#comment-13738310
 ] 

Suresh Srinivas edited comment on HDFS-5055 at 8/13/13 2:54 PM:
----------------------------------------------------------------

[~vinayrpet] Thanks for jumping on this. The patch looks good. I updated the 
patch with a small change.
Instead of:
{code}
   String machine = imageListenAddress.getHostName();
   if (machine == null || machine.isEmpty() || machine.equals("0.0.0.0")) {
     machine = null;
   }
{code}

the updated patch has:
{code}
   String machine = imageListenAddress.getAddress().isAnyLocalAddress() ? 
     null : imageListenAddress.getHostName();
{code}

                
      was (Author: sureshms):
    [~vinayrpet] Thanks for jumping on this. The patch looks good. I updated 
the patch with a small change.
Instead of:
{code}
   String machine = imageListenAddress.getHostName();
   if (machine == null || machine.isEmpty() || machine.equals("0.0.0.0")) {
     machine = null;
   }
{code}

the update patch has:
{code}
   String machine = imageListenAddress.getAddress().isAnyLocalAddress() ? 
     null : imageListenAddress.getHostName();
{code}

                  
> nn->2nn ignores dfs.namenode.secondary.http-address
> ---------------------------------------------------
>
>                 Key: HDFS-5055
>                 URL: https://issues.apache.org/jira/browse/HDFS-5055
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.1.0-beta
>            Reporter: Allen Wittenauer
>            Assignee: Vinay
>            Priority: Blocker
>              Labels: regression
>         Attachments: HDFS-5055.patch, HDFS-5055.patch
>
>
> The primary namenode attempts to connect back to (incoming hostname):port 
> regardless of how dfs.namenode.secondary.http-address is configured.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to