[
https://issues.apache.org/jira/browse/HDFS-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Agarwal updated HDFS-4985:
--------------------------------
Attachment: h4985.04.patch
Thanks for the review Nicholas.
{quote}
Do we really need enum StorageType as a public API in Common?
{quote}
We would need to expose it to applications when we start adding Storage
Preferences.
{quote}
StorageType.DEFAULT should be defined as static, i.e.
{quote}
Fixed.
{quote}
StorageType and StorageTypeProto do not match - StorageType has DISK, SSD
and DEFAULT but StorageTypeProto has UNKNOWN, DISK and SSD. Also the numeric
values do not match, e.g. StorageType.DISK is 0 but StorageTypeProto.DISK is 1.
{quote}
Fixed. I wanted to decouple the wire type and StorageType so we don't assume
that disk is the default in the proto message. I matched the numerical values
now but the default on the wire is different value from StorageType.DISK. What
do you think?
> Add storage type to the protocol and expose it in block report and block
> locations
> ----------------------------------------------------------------------------------
>
> Key: HDFS-4985
> URL: https://issues.apache.org/jira/browse/HDFS-4985
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: 3.0.0
> Reporter: Suresh Srinivas
> Assignee: Arpit Agarwal
> Attachments: h4985.02.patch, h4985.04.patch
>
>
> With HDFS-2880 datanode now supports storage abstraction. This is to add
> storage type in to the protocol. Datanodes currently report blocks per
> storage. Storage would include storage type attribute. Namenode also exposes
> the storage type of a block in block locations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
