[
https://issues.apache.org/jira/browse/HDFS-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13745709#comment-13745709
]
Tsz Wo (Nicholas), SZE commented on HDFS-4985:
----------------------------------------------
> ... I wanted to decouple the wire type and StorageType so we don't assume
> that disk is the default in the proto message. I matched the numerical values
> now but the default on the wire is different value from StorageType.DISK.
> What do you think?
Then, it is better to have an UNKNOWN type as in your previous patch. I think
it is okay to match the Java type with the protobuf type, i.e. StorageType and
StorageTypeProto should correspond to each other. StorageTypeProto should also
be moved to Common. For individual implementations such as HDFS, they can
define the default value when the received value is UNKNOWN. Sounds good?
> Add storage type to the protocol and expose it in block report and block
> locations
> ----------------------------------------------------------------------------------
>
> Key: HDFS-4985
> URL: https://issues.apache.org/jira/browse/HDFS-4985
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: 3.0.0
> Reporter: Suresh Srinivas
> Assignee: Arpit Agarwal
> Attachments: h4985.02.patch, h4985.04.patch
>
>
> With HDFS-2880 datanode now supports storage abstraction. This is to add
> storage type in to the protocol. Datanodes currently report blocks per
> storage. Storage would include storage type attribute. Namenode also exposes
> the storage type of a block in block locations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
