[
https://issues.apache.org/jira/browse/HDFS-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746914#comment-13746914
]
Chris Nauroth commented on HDFS-5045:
-------------------------------------
Hi, Jing. The new tests look great. I ran them multiple times on Windows, and
everything worked as expected.
I have a minor comment about this:
{code}
private final Map<String, Object> results = new HashMap<String, Object>();
{code}
It seems unnecessary for {{results}} to be a member variable storing the
results of all ops from all tests. Each particular op result only gets
accessed within the scope of one invocation of {{testClientRetryWithFailover}},
so I think this could move to a local variable within
{{testClientRetryWithFailover}}. It could be {{final Map<String, Object>}}, or
it could just be {{final Mutable<Object>}}, considering that the value is the
only important part to remember and the key would be redundant with {{op.name}}.
> Add more unit tests for retry cache to cover all AtMostOnce methods
> -------------------------------------------------------------------
>
> Key: HDFS-5045
> URL: https://issues.apache.org/jira/browse/HDFS-5045
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Priority: Minor
> Attachments: HDFS-5045.001.patch, HDFS-5045.002.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
