[
https://issues.apache.org/jira/browse/HDFS-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749164#comment-13749164
]
Andrew Wang commented on HDFS-5121:
-----------------------------------
Neato patch, some comments:
Nitty things:
- BatchedCachePoolEntries and BatchedPathCacheEntries look exactly the same
except for the type; can we further generic this duplication away?
- If the "not null" aspect of CachePool is significant, you could add
{{@NotNull}} annotations to reflect that.
- Eclipse is telling me these are unchecked casts:
{code}
return (List<Fallible<PathCacheEntry>>) retryCacheEntry.getPayload();
...
return (List<Fallible<Long>>) retryCacheEntry.getPayload();
{code}
The rest:
- We normally do all our permission checks in {{FSNamesystem}} and
{{FSPermissionChecker}} via something like {{pc.checkPermission}}. Rather than
passing down {{pc}}, how about some new methods in {{FSPermissionChecker}} that
operate on cache pools?
- You might find the {{FsPermission}} class useful for representing the mode.
Also gives you the all important sticky bit support ;)
- No {{addCachePool}} API? Logically, add should create a new pool and fail if
the pool already exists. modify should operate on existing pools and fail if
the pool doesn't exist. I think admins would want both so they don't
accidentally create a new pool when they fat-finger trying to modify an
existing one.
> add RPCs for creating and manipulating cache pools
> --------------------------------------------------
>
> Key: HDFS-5121
> URL: https://issues.apache.org/jira/browse/HDFS-5121
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: HDFS-4949
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-5121-caching.001.patch
>
>
> We should add RPCs for creating and manipulating cache pools.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
