[
https://issues.apache.org/jira/browse/HDFS-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Wang updated HDFS-5121:
------------------------------
Attachment: hdfs-5121-3.patch
Here's a v3 patch based on Colin's v2. I did a fairly big rework, high order
bits:
- Made permission checks use {{FsPermission}} and {{FsAction}}.
{{FSPermissionChecker}} still gets passed down to {{CacheManager}}, can't do it
all in FSNamesystem.
- Added permission check for execute to {{listPathCacheEntries}}, removed read
permissions to see "full" CachePool metadata in {{listCachePools}}.
- Use a long to uniquely identify CachePools. Reworked client interfaces to use
this id and CachePoolInfo where appropriate. Lets us also be more idempotent
with some CachePool operations.
- Did a PB rework to use new CachePoolProto and CachePoolInfoProto types. In
some places I use CachePoolProto just to hold the pool id, but on the client/NN
side they should just see a long.
Smaller things worth mentioning:
- Made {{addCachePool}} return the created {{CachePool}}, kind of like a file
handle
- Refactored CachePoolInfo's builder-like methods out into an actual Builder
- Removed the setters from CachePool, since they're all in CachePoolInfo now.
- Also rolled up an additional test fix for TestFsDatasetCache
Potential follow-on work:
- Some error messages are less human readable since they now use pool IDs
instead of strings. Audit log messages could also use some love.
> add RPCs for creating and manipulating cache pools
> --------------------------------------------------
>
> Key: HDFS-5121
> URL: https://issues.apache.org/jira/browse/HDFS-5121
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: HDFS-4949
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: hdfs-5121-3.patch, HDFS-5121-caching.001.patch,
> HDFS-5121-caching.002.patch
>
>
> We should add RPCs for creating and manipulating cache pools.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
